Re: [Buildroot] [PATCH 2/2] Check if bootcurrent is valid before using it

Hi Rhidian!

Am 24.08.26 um 13:20 schrieb Rhidian De Wit:
> I am actually trying to commit add these patches to buildroot, but I wasn't
> fully sure how to approach this. Looking at the zip package for example, it
> also has patches for files in the zip project that aren't in the buildroot
> repository itself.
> I assumed this was fine to do, but I probably messed a step up, how would I
> go about adding patches for RAUC in buildroot?
> I've already submitted PRs for the bugfixes in the RAUC project itself, but
> I assume that won't be in for a while, as the last RAUC release is from 5
> months ago.

In that case you need to add the patch files to the package directory in 
Buildroot (they will be applied to the sources during build), and send a 
commit adding the patch files to the Buildroot ML. The process is 
described in detail in chapter 19 "Patching a package" of the manual 
[1]. Short version:

* Make your commits in the RAUC repo
* Create patch file(s) using "git format-patch -N"
* Put them into the package dir (here: package/rauc/)
* Add an "Upstream:" trailer to each patch (together with your s-o-b), 
with the PR URL(s)
* Test your patched package (I assume you have some Buildroot build 
using RAUC), you should see patches being applied in build output before 
configure
* Commit
* Run "./utils/docker-run make check-package" to check for any style 
issues (check-package only looks at paths that exist in the Git repo, so 
if you add new files you need to commit first)
* Once everything's good, send a patch for that commit to the RAUC ML [2].

You did the "sending patch to ML" part right already, it just wasn't the 
right kind of patch. ;-)

> The second one seems to have some indentation issues.

I mean in the C code. Your changes are indented by 2 spaces per 
indentation level, not with one tab per level like the rest of the RAUC 
code. That is something to fix in your commits in the RAUC repo before 
you create the patch files (and push to the PR, so reviewers can focus 
on the code).

Best regards,
Fiona


[1] https://nightly.buildroot.org/#patch-policy
[2] https://nightly.buildroot.org/#submitting-patches
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot