[Buildroot] [git commit] package/taglib: mp4 support needs threads

commit: https://gitlab.com/buildroot.org/buildroot/-/commit/1a0a2134e6e632852e23ca8cc583af7ea347ec6d
branch: https://gitlab.com/buildroot.org/buildroot/-/tree/master

Buildroot commit 1c5730ebb5e8b9a67433aa9997e5cfd6cae18cfe bumped the
package from version 2.2.1 to version 2.3 which includes upstream commit
https://github.com/taglib/taglib/commit/5d63187a8b8d291cbf4f77d1bb973bc5ee91cf03
that uses std::call_once and is only available with threads support.

Inspired by buildroot commit f9a2d65cae88ca7c641af2f69161ab0d21bac91c
which fixed a similar error.

This patch fixes a build error

/builds/bkuhls/buildroot/br-test-pkg/br-arm-full-nothread/build/taglib-2.3/taglib/mp4/mp4itemfactory.cpp:51:16:
 error: ‘once_flag’ in namespace ‘std’ does not name a type

caught by the Gitlab pipelines. To reproduce use this defconfig:

  BR2_arm=y
  BR2_arm1176jzf_s=y
  BR2_TOOLCHAIN_EXTERNAL=y
  BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
  BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
  BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm11-full-nothread-2020.11.2.tar.bz2"
  BR2_TOOLCHAIN_EXTERNAL_GCC_9=y
  BR2_TOOLCHAIN_EXTERNAL_HEADERS_5_9=y
  BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
  # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS is not set
  BR2_TOOLCHAIN_EXTERNAL_CXX=y
  BR2_PER_PACKAGE_DIRECTORIES=y
  BR2_PACKAGE_TAGLIB=y

Signed-off-by: Bernd Kuhls <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
---
 package/taglib/taglib.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/taglib/taglib.mk b/package/taglib/taglib.mk
index 924d3f339d..9a111a86c6 100644
--- a/package/taglib/taglib.mk
+++ b/package/taglib/taglib.mk
@@ -12,6 +12,12 @@ TAGLIB_LICENSE = LGPL-2.1 or MPL-1.1
 TAGLIB_LICENSE_FILES = COPYING.LGPL COPYING.MPL
 TAGLIB_CPE_ID_VENDOR = taglib
 
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+TAGLIB_CONF_OPTS += -DWITH_MP4=ON
+else
+TAGLIB_CONF_OPTS += -DWITH_MP4=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 TAGLIB_DEPENDENCIES += zlib
 TAGLIB_CONF_OPTS += -DWITH_ZLIB=ON

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot