Re: [Buildroot] [PATCH/RFC 2/3] package/taglib: needs gcc >= 7

On Fri, Jul 24, 2026 at 06:48:28PM +0200, Bernd Kuhls wrote:
> Fixes a build error caught by the Gitlab pipelines:
> 
> /builds/bkuhls/buildroot/br-test-pkg/bootlin-aarch64-glibc-old/build/taglib-2.3/taglib/mpeg/mpegfile.cpp:113:10:
>  error: expected primary-expression before ‘const’
>        if(const Header header(&file, headerOffset + i, true); header.isValid()) {
> 
> which was introduced by code format changes in upstream commit
> https://github.com/taglib/taglib/commit/dfe2aa52532fc9f73a67499dd17fb527a856a22f
> 
> which was first released with taglib 2.0, added to buildroot with commit
> 9cd3464afa13fd0190fb3e94fd850cc8063cf297.
> 
> Signed-off-by: Bernd Kuhls <[email protected]>
> ---
> I have no idea if this patch is correct, at least blocking gcc 6 makes
> the Gitlab pipelines happy. It seems to me that the upstream commit uses
> newer language features not supported by gcc 6, but with my limited
> knowledge about C++ I could not find evidence to support my theory.

I'm also not a C++ guru, but some research shows that this is called
"init-statement", was described by proposal P0305R1 and according to
https://en.cppreference.com/cpp/compiler_support/17 this feature
indeed has been supported since gcc 7.

I've extended the commit log with this information, and applied to
master. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot