Re: [Buildroot] [PATCH v2] package/tcl: bump to version 9.0.3
Thomas Petazzoni via buildroot <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <aoyoCY6c2qTJcRxz@windsurf> |
Hello, On Mon, Aug 10, 2026 at 05:01:52PM +0530, Shubham Chakraborty wrote: > -TCL_VERSION_MAJOR = 8.6 > -TCL_VERSION = $(TCL_VERSION_MAJOR).15 > +TCL_VERSION_MAJOR = 9.0 > +TCL_VERSION = $(TCL_VERSION_MAJOR).3 > TCL_SOURCE = tcl$(TCL_VERSION)-src.tar.gz > TCL_SITE = http://downloads.sourceforge.net/project/tcl/Tcl/$(TCL_VERSION) > TCL_LICENSE = TCL > @@ -73,9 +73,19 @@ define TCL_REMOVE_EXTRA > endef > TCL_POST_INSTALL_TARGET_HOOKS += TCL_REMOVE_EXTRA > > +define HOST_TCL_SYMLINK_TCLSH > + ln -sf tclsh$(TCL_VERSION_MAJOR) $(HOST_DIR)/bin/tclsh > +endef > +HOST_TCL_POST_INSTALL_HOOKS += HOST_TCL_SYMLINK_TCLSH Are you sure you need to symlink, since... > + > +TCL_MAKE_OPTS = \ > + TCLSH="$(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR)" \ > + TCLSH_PROG="$(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR)" ... you're passing the full path to $(HOST_DIR)/bin/tclsh$(TCL_VERSION_MAJOR) here? From my quick experiment, it seems like the symlink is not needed. Also, could you verify that both TCLSH= and TCLSH_PROG= are needed? > + > TCL_DEPENDENCIES = $(if $(BR2_PACKAGE_SQLITE),sqlite) \ > $(if $(BR2_PACKAGE_MARIADB),mariadb) \ > $(if $(BR2_PACKAGE_POSTGRESQL),postgresql) \ > + host-tcl \ > zlib With your patch: - host-tcl fails to build because <zlib.h> is not found. Seems like host-zlib is now needed as a dependency of host-tcl. Make sure to build in a minimal Docker container to figure out this kind of issue. You can trivially do that in Buildroot: "./utils/docker-run make". - tcllib fails to build, because version 1.21 is not designed to work with Tcl 9.0, you need to bump tcllib to 2.0 apparently. Could you look into these different issues, and get back to us with an updated patch? Thanks a lot! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot