Re: [f2fs-dev] [PATCH v2 08/17] ext4: Make ext4_bio_write_folio() return void
Eric Biggers via Linux-f2fs-devel <[email protected]>
| Newsgroups | net.sourceforge.lists.linux-f2fs-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <20260705202727.GJ41916@quark> |
On Sun, Jul 05, 2026 at 12:45:45PM -0700, Eric Biggers wrote:
> @@ -2724,9 +2711,7 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
> * through a pin.
> */
> if (!mpd->can_map) {
> - err = mpage_submit_folio(mpd, folio);
> - if (err < 0)
> - goto out;
> + mpage_submit_folio(mpd, folio);
> /* Pending dirtying of journalled data? */
> if (folio_test_checked(folio)) {
> err = mpage_journal_page_buffers(handle,
Sashiko found a subtle bug here, where removing this assignment to 'err'
can leak a positive 'err' value of 1 from ext4_journal_ensure_credits()
into the caller of mpage_prepare_extent_to_map() in certain cases.
I'll fix that by leaving an assignment of 0 to 'err' here.
Really, positive values shouldn't be stored in a variable named 'err' in
the first place though.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel