Re: [f2fs-dev] [PATCHv2 3/5] xfs: report direct io attributes through file_getattr

On Fri, Jul 10, 2026 at 02:06:44PM -0700, Keith Busch wrote:
> +static void
> +xfs_fill_fsxattr_dio(
> +	struct xfs_inode	*ip,
> +	int			whichfork,
> +	struct file_kattr	*fa)
> +{
> +	struct xfs_buftarg *target;

Same alignment for the variables as for the arguments.

> +
> +	if (whichfork != XFS_DATA_FORK || !S_ISREG(VFS_I(ip)->i_mode))
> +		return;

Move this check to th caller?  Although this and similar check in
the other file system patches miss block device nodes, for which we'd
need a special case, or one in the caller to override the attrs.

Or maybe using the file attr for this isn't actually a good idea,
and we should do an ioctl instead which automatically gets routed to
the block device fops?

> +	target = xfs_inode_buftarg(ip);

.. and initialize the variable at declaration time?



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel