Re: [f2fs-dev] [PATCH v1 05/12] f2fs: cache: use meta cache
Chao Yu via Linux-f2fs-devel <[email protected]>
| Newsgroups | net.sourceforge.lists.linux-f2fs-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/23/26 20:55, Wenjie Qi wrote:
> Hi Chao,
>
>> struct f2fs_cached_block *f2fs_get_sum_cache(struct f2fs_sb_info *sbi,
>> unsigned int segno)
>> {
>> if (unlikely(f2fs_cp_error(sbi)))
>> return ERR_PTR(-EIO);
>> return f2fs_get_meta_cache_retry(sbi, GET_SUM_BLOCK(sbi, segno));
>> }
>>
>> entry = f2fs_get_sum_cache(sbi, GET_SUM_BLOCK(sbi, segno));
>
> `f2fs_get_sum_cache()` applies `GET_SUM_BLOCK()` to its argument. Its other
> callers pass a logical segment number, while this packed-SSA path passes an
> already translated value.
>
> Is the argument contract of `f2fs_get_sum_cache()` a logical segment number
> or an already translated block address?
Oops, should use f2fs_get_sum_cache(sbi, segno) here.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel