[Openvpn-devel] [L] Change in openvpn[master]: oob: Add SERVER_PROBE parsing and the probe-reply decision

Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1742?usp=email )

Change subject: oob: Add SERVER_PROBE parsing and the probe-reply decision
......................................................................


Patch Set 8:

(2 comments)

File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1742/comment/2e88f7a7_bfed1fb6?usp=email :
PS7, Line 187:     while (BLEN(payload) >= 4)
> Instead of hardcoding that 4 why not do `while(oob_tlv_read_header(... […]
Fixed.


http://gerrit.openvpn.net/c/openvpn/+/1742/comment/74431fcd_2182b6c0?usp=email :
PS7, Line 232:     memset(reply, 0, sizeof(*reply));
> Should probably use CLEAR() macro
Fixed.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1742?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iafa9efc1c156974ad9f5752e9de810a8c2f68c30
Gerrit-Change-Number: 1742
Gerrit-PatchSet: 8
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 12:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel