[Openvpn-devel] [S] Change in openvpn[master]: dco.c: make key state desync recoverable

Attention is currently required from: plaisthos, ralf_lici.

ordex has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1795?usp=email )

Change subject: dco.c: make key state desync recoverable
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/dco.c:

http://gerrit.openvpn.net/c/openvpn/+/1795/comment/001f01ed_274820a2?usp=email :
PS2, Line 203:             ASSERT(secondary->dco_status == DCO_INSTALLED_PRIMARY);
should we also convert this ASSERT() since it's basically part of the same class of problems? Similarly to the one you are converting above, maybe this one should get the same treatment?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1795?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d0887839b4a13a92e92250d1b315dec949698f3
Gerrit-Change-Number: 1795
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 13:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel