[Openvpn-devel] [XS] Change in openvpn[master]: Remove --providers option for Mbed TLS

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1799?usp=email

to review the following change.


Change subject: Remove --providers option for Mbed TLS
......................................................................

Remove --providers option for Mbed TLS

This is an OpenSSL-only option, so remove it from option parsing when
building with Mbed TLS. Previously, OpenVPN would print a warning and
not do anything with the providers.

Change-Id: I0f56ca69efae0ca376eb9eae064a893c8768188e
Signed-off-by: Max Fillinger <[email protected]>
---
M src/openvpn/options.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1799/1

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 87218d4..d68210a 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -606,7 +606,9 @@
     "                : Use --show-tls to see a list of supported TLS ciphers (suites).\n"
     "--tls-cert-profile p : Set the allowed certificate crypto algorithm profile\n"
     "                  (default=legacy).\n"
+#ifndef ENABLE_CRYPTO_MBEDTLS
     "--providers l   : A list l of OpenSSL providers to load.\n"
+#endif
     "--tls-timeout n : Packet retransmit timeout on TLS control channel\n"
     "                  if no ACK from remote within n seconds (default=%d).\n"
     "--reneg-bytes n : Renegotiate data chan. key after n bytes sent and recvd.\n"
@@ -8575,7 +8577,6 @@
             options->engine = "auto";
         }
     }
-#endif /* ENABLE_CRYPTO_MBEDTLS */
     else if (streq(p[0], "providers") && p[1])
     {
         for (size_t j = 1; j < MAX_PARMS && p[j] != NULL; j++)
@@ -8583,6 +8584,7 @@
             options->providers.names[j] = p[j];
         }
     }
+#endif /* ENABLE_CRYPTO_MBEDTLS */
     else if (streq(p[0], "show-tls") && !p[1])
     {
         VERIFY_PERMISSION(OPT_P_GENERAL);

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1799?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f56ca69efae0ca376eb9eae064a893c8768188e
Gerrit-Change-Number: 1799
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel