[Openvpn-devel] [XS] Change in openvpn[master]: Correctly calculate packet id size when epoch is in use

Attention is currently required from: plaisthos.

ordex has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1829?usp=email )

Change subject: Correctly calculate packet id size when epoch is in use
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
I think the commit message is quite misleading. From it I understand you are fixing some notation to make the computation more clear.
But from the GH report I understand this is really fixing the computation (the commit title agrees).

Maybe the commit message is justifying why you are doing things this way, rather than setting packet_id_long_form to true?

Still, I think you should add a line explaining what we are fixing: i.e. the packet ID size computation was not considering the epoch case and was falling back to XX bytes, which is smaller than expected, resulting in MTU screw up


File src/openvpn/mtu.c:

http://gerrit.openvpn.net/c/openvpn/+/1829/comment/3ac069bb_6ba4a15b?usp=email :
PS1, Line 59:         return sizeof(uint64_t);
since we don't have explicit members to call sizeof() on, how about a little comment explaining the meaning behind the magic uint64_t?

i.e. /* 16 bit epoch + 48 bit IV */



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1829?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5b862eabe032eb4d2229ff5b2f4f6af7406f6f4e
Gerrit-Change-Number: 1829
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 19:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel