[Openvpn-devel] [L] Change in openvpn[master]: Move schedule test to a unit test
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Wed, 29 Jul 2026 12:01:41 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <ee08af62452e747d9b43879b1a755176cd625b93-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============3044012863039707636== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="hAR44luvFnA="; charset=UTF-8 --hAR44luvFnA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1828?usp=3Demail ) Change subject: Move schedule test to a unit = test =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 4: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/test_sche= dule=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment/6917016e_= d4b4df7a?usp=3Demail : PS4, Line 91: ASSERT(e !=3D e->lt); We shoul= d change these to proper cmocka asserts, but not sure whether it is better = to do that in a separate commit? http://gerrit=2Eopenvpn=2Enet/c/openvpn/= +/1828/comment/c1735282_e178d672?usp=3Demail : PS4, Line 168: #else /* if = 1 */ Does this code still have value? If so, then we should integrate it in= to the test=2E If not, maybe just delete it? http://gerrit=2Eopenvpn=2Ene= t/c/openvpn/+/1828/comment/3ce2fabc_9e5f4fc4?usp=3Demail : PS4, Line 173: = struct gc_arena gc =3D gc_new(); gc seems to be unused? -- To view, = visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828?usp=3Demail To unsubsc= ribe, or for help writing mail filters, visit http://gerrit=2Eopenvpn=2Enet= /settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn = Gerrit-Branch: master Gerrit-Change-Id: Ie33aea26026e07c860da7d79880cef6b27= b7b0e8 Gerrit-Change-Number: 1828 Gerrit-PatchSet: 4 Gerrit-Owner: plaistho= s <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichtenheld <frank@lichten= held=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2En= et> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Comment= -Date: Wed, 29 Jul 2026 12:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-L= abels: Yes --hAR44luvFnA= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 4:<span style=3D"borde= r-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgroun= d-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2Eo= penvpn=2Enet/c/openvpn/+/1828?usp=3Demail">View Change</a></p><p>3 comments= :</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pa= dding: 0;"><p>File tests/unit_tests/openvpn/test_schedule=2Ec:</p><ul style= =3D"list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 1= 6px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1828/comment/6917016e_d4b4df7a?usp=3Demail">Patch Set #4= , Line 91:</a> <code style=3D"font-family:monospace,monospace"> ASSE= RT(e !=3D e->lt);</code></p><p class=3D"blocks" style=3D"white-space: pr= e-wrap; word-wrap: break-word;">We should change these to proper cmocka ass= erts, but not sure whether it is better to do that in a separate commit?</p= ></li><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bott= om: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment= /c1735282_e178d672?usp=3Demail">Patch Set #4, Line 168:</a> <code style=3D"= font-family:monospace,monospace">#else /* if 1 */</code></p><p class=3D"bl= ocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">Does this cod= e still have value? If so, then we should integrate it into the test=2E If = not, maybe just delete it?</p></li><li style=3D"margin: 0; padding: 0 0 0 1= 6px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1828/comment/3ce2fabc_9e5f4fc4?usp=3Demail">Patch Set #4= , Line 173:</a> <code style=3D"font-family:monospace,monospace"> struct = gc_arena gc =3D gc_new();</code></p><p class=3D"blocks" style=3D"white-spac= e: pre-wrap; word-wrap: break-word;">gc seems to be unused?</p></li></ul></= li></ul><p>To view, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvp= n/+/1828?usp=3Demail">change 1828</a>=2E To unsubscribe, or for help writin= g mail filters, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp= =3Demail">settings</a>=2E</p><div itemscope itemtype=3D"http://schema=2Eorg= /EmailMessage"><div itemscope itemprop=3D"action" itemtype=3D"http://schema= =2Eorg/ViewAction"><link itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1828?usp=3Demail"/><meta itemprop=3D"name" content=3D"Vi= ew Change"/></div></div> <div style=3D"display:none"> Gerrit-MessageType: = comment </div> <div style=3D"display:none"> Gerrit-Project: openvpn </div> = <div style=3D"display:none"> Gerrit-Branch: master </div> <div style=3D"dis= play:none"> Gerrit-Change-Id: Ie33aea26026e07c860da7d79880cef6b27b7b0e8 </d= iv> <div style=3D"display:none"> Gerrit-Change-Number: 1828 </div> <div sty= le=3D"display:none"> Gerrit-PatchSet: 4 </div> <div style=3D"display:none">= Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <div sty= le=3D"display:none"> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2E= com> </div> <div style=3D"display:none"> Gerrit-CC: openvpn-devel <op= envpn-devel@lists=2Esourceforge=2Enet> </div> <div style=3D"display:none= "> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <d= iv style=3D"display:none"> Gerrit-Comment-Date: Wed, 29 Jul 2026 12:01:41 += 0000 </div> <div style=3D"display:none"> Gerrit-HasComments: Yes </div> <di= v style=3D"display:none"> Gerrit-Has-Labels: Yes </div> </body></html> --hAR44luvFnA=-- --===============3044012863039707636== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============3044012863039707636== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============3044012863039707636==--