[Openvpn-devel] [M] Change in openvpn[master]: Change hash iv to a be a fixed sized array
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Wed, 29 Jul 2026 14:04:56 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <4bb907161fe50d288d4bcb3c81cced612018f598-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============7638951066330066000== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TqAMgG62J1A="; charset=UTF-8 --TqAMgG62J1A= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1571?usp=3Demail ) Change subject: Change hash iv to a be a fixe= d sized array =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 19: Code-Review-1 (2 comments) File src/openvpn/list=2Ec: h= ttp://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/1a426261_45a9bafa?usp= =3Demail : PS19, Line 425: hash_func_new_ctx(void) forgot to remove? File= src/openvpn/multi=2Ec: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/com= ment/1b99989b_137b6581?usp=3Demail : PS19, Line 313: * value and funct= ion for the context parameters=2E comment is obsolete -- To view, visit= http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail To unsubscribe,= or for help writing mail filters, visit http://gerrit=2Eopenvpn=2Enet/sett= ings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerri= t-Branch: master Gerrit-Change-Id: If47c7d920b2fa4047b7db03fcde821899839324= d Gerrit-Change-Number: 1571 Gerrit-PatchSet: 19 Gerrit-Owner: plaisthos <a= rne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichtenheld <frank@lichtenheld= =2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> = Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Comment-Dat= e: Wed, 29 Jul 2026 14:04:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Label= s: Yes --TqAMgG62J1A= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 19:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/1571?usp=3Demail">View Change</a></p><p>2 comment= s:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; p= adding: 0;"><p>File src/openvpn/list=2Ec:</p><ul style=3D"list-style: none;= padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"mar= gin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571= /comment/1a426261_45a9bafa?usp=3Demail">Patch Set #19, Line 425:</a> <code = style=3D"font-family:monospace,monospace">hash_func_new_ctx(void)</code></p= ><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;= ">forgot to remove?</p></li></ul></li><li style=3D"margin: 0; padding: 0;">= <p>File src/openvpn/multi=2Ec:</p><ul style=3D"list-style: none; padding: 0= ;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom:= 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/1b= 99989b_137b6581?usp=3Demail">Patch Set #19, Line 313:</a> <code style=3D"fo= nt-family:monospace,monospace"> * value and function for the context pa= rameters=2E</code></p><p class=3D"blocks" style=3D"white-space: pre-wrap; w= ord-wrap: break-word;">comment is obsolete</p></li></ul></li></ul><p>To vie= w, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Dem= ail">change 1571</a>=2E To unsubscribe, or for help writing mail filters, v= isit <a href=3D"http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">setting= s</a>=2E</p><div itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><d= iv itemscope itemprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction= "><link itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/= 1571?usp=3Demail"/><meta itemprop=3D"name" content=3D"View Change"/></div><= /div> <div style=3D"display:none"> Gerrit-MessageType: comment </div> <div= style=3D"display:none"> Gerrit-Project: openvpn </div> <div style=3D"displ= ay:none"> Gerrit-Branch: master </div> <div style=3D"display:none"> Gerrit-= Change-Id: If47c7d920b2fa4047b7db03fcde821899839324d </div> <div style=3D"d= isplay:none"> Gerrit-Change-Number: 1571 </div> <div style=3D"display:none"= > Gerrit-PatchSet: 19 </div> <div style=3D"display:none"> Gerrit-Owner: pla= isthos <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"display:none= "> Gerrit-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> </div> <di= v style=3D"display:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists= =2Esourceforge=2Enet> </div> <div style=3D"display:none"> Gerrit-Attenti= on: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <div style=3D"displ= ay:none"> Gerrit-Comment-Date: Wed, 29 Jul 2026 14:04:56 +0000 </div> <div = style=3D"display:none"> Gerrit-HasComments: Yes </div> <div style=3D"displa= y:none"> Gerrit-Has-Labels: Yes </div> </body></html> --TqAMgG62J1A=-- --===============7638951066330066000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7638951066330066000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============7638951066330066000==--