[Openvpn-devel] [L] Change in openvpn[master]: Move schedule test to a unit test
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Wed, 29 Jul 2026 18:41:56 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <67151777ab6f6b0ce79cd3128e6ddbfbc4c26f92-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============7767750567626729621== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="iqUncAMpLAQ="; charset=UTF-8 --iqUncAMpLAQ= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld=2E plaisthos has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1828?usp=3Demail ) Change subject: Move schedule test to a unit = test =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 4: (3 comments) File tests/unit_tests/openvpn/test_schedule=2Ec: htt= p://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment/f593a9d2_556a11ff?usp= =3Demail : PS4, Line 91: ASSERT(e !=3D e->lt); > We should change t= hese to proper cmocka asserts, but not sure whether it is better to do that= in a s [=E2=80=A6] Done=2E I think it is okay to in the same commit as thi= s is a unit test rather than code that is run in production=2E http://ger= rit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment/c52a43d2_a945fe3a?usp=3Demail = : PS4, Line 168: #else /* if 1 */ > Does this code still have value? If so= , then we should integrate it into the test=2E [=E2=80=A6] Done http://ge= rrit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment/8118172d_b4beb993?usp=3Demail= : PS4, Line 173: struct gc_arena gc =3D gc_new(); > gc seems to be unu= sed? Done -- To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1= 828?usp=3Demail To unsubscribe, or for help writing mail filters, visit htt= p://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-MessageType: commen= t Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie33aea26= 026e07c860da7d79880cef6b27b7b0e8 Gerrit-Change-Number: 1828 Gerrit-PatchSet= : 4 Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: f= lichtenheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-dev= el@lists=2Esourceforge=2Enet> Gerrit-Attention: flichtenheld <frank@lichten= held=2Ecom> Gerrit-Comment-Date: Wed, 29 Jul 2026 18:41:56 +0000 Gerrit-Has= Comments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fran= k@lichtenheld=2Ecom> --iqUncAMpLAQ= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: flichtenheld=2E </p> <p><a href=3D"http://gerrit=2Eop= envpn=2Enet/c/openvpn/+/1828?usp=3Demail">View Change</a></p><p>3 comments:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>File tests/unit_tests/openvpn/test_schedule=2Ec:</p><ul style= =3D"list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 1= 6px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1828/comment/f593a9d2_556a11ff?usp=3Demail">Patch Set #4= , Line 91:</a> <code style=3D"font-family:monospace,monospace"> ASSE= RT(e !=3D e->lt);</code></p><p><blockquote style=3D"border-left: 1px sol= id #aaa; margin: 10px 0; padding: 0 10px;">We should change these to proper= cmocka asserts, but not sure whether it is better to do that in a s [=E2= =80=A6]</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wrap;= word-wrap: break-word;">Done=2E I think it is okay to in the same commit a= s this is a unit test rather than code that is run in production=2E</p></li= ><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4= px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828/comment/c52a= 43d2_a945fe3a?usp=3Demail">Patch Set #4, Line 168:</a> <code style=3D"font-= family:monospace,monospace">#else /* if 1 */</code></p><p><blockquote styl= e=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Does th= is code still have value? If so, then we should integrate it into the test= =2E [=E2=80=A6]</blockquote></p><p class=3D"blocks" style=3D"white-space: p= re-wrap; word-wrap: break-word;">Done</p></li><li style=3D"margin: 0; paddi= ng: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit= =2Eopenvpn=2Enet/c/openvpn/+/1828/comment/8118172d_b4beb993?usp=3Demail">Pa= tch Set #4, Line 173:</a> <code style=3D"font-family:monospace,monospace"> = struct gc_arena gc =3D gc_new();</code></p><p><blockquote style=3D"borde= r-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">gc seems to be un= used?</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wrap; w= ord-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a hre= f=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828?usp=3Demail">change 182= 8</a>=2E To unsubscribe, or for help writing mail filters, visit <a href=3D= "http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><di= v itemscope itemtype=3D"http://schema=2Eorg/EmailMessage"><div itemscope it= emprop=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction"><link itempro= p=3D"url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1828?usp=3Demai= l"/><meta itemprop=3D"name" content=3D"View Change"/></div></div> <div sty= le=3D"display:none"> Gerrit-MessageType: comment </div> <div style=3D"displ= ay:none"> Gerrit-Project: openvpn </div> <div style=3D"display:none"> Gerri= t-Branch: master </div> <div style=3D"display:none"> Gerrit-Change-Id: Ie33= aea26026e07c860da7d79880cef6b27b7b0e8 </div> <div style=3D"display:none"> G= errit-Change-Number: 1828 </div> <div style=3D"display:none"> Gerrit-PatchS= et: 4 </div> <div style=3D"display:none"> Gerrit-Owner: plaisthos <arne-= openvpn@rfc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Review= er: flichtenheld <frank@lichtenheld=2Ecom> </div> <div style=3D"displ= ay:none"> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2E= net> </div> <div style=3D"display:none"> Gerrit-Attention: flichtenheld = <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none"> Gerrit-= Comment-Date: Wed, 29 Jul 2026 18:41:56 +0000 </div> <div style=3D"display:= none"> Gerrit-HasComments: Yes </div> <div style=3D"display:none"> Gerrit-H= as-Labels: No </div> <div style=3D"display:none"> Comment-In-Reply-To: flic= htenheld <frank@lichtenheld=2Ecom> </div> </body></html> --iqUncAMpLAQ=-- --===============7767750567626729621== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7767750567626729621== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============7767750567626729621==--