[Openvpn-devel] [M] Change in openvpn[master]: Change hash iv to a be a fixed sized array
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 10:21:08 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <2f5b02729c9f6afdea48843542b6fcb94d56ec36-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============7265226882522976115== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="NrmgbwavIVE="; charset=UTF-8 --NrmgbwavIVE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1571?usp=3Demail ) The change is no longer submittable: Code-Rev= iew is unsatisfied now=2E Change subject: Change hash iv to a be a fixed s= ized array =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 20: Code-Review-1 (2 comments) File src/openvpn/mroute=2Ec: ht= tp://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/400191c1_fbfefae1?usp= =3Demail : PS20, Line 361: mroute_addr_hash_len((const= struct mroute_addr *)key), *(int32_t *)hash_key); Should be `uint32_t*` = File tests/unit_tests/openvpn/test_misc=2Ec: http://gerrit=2Eopenvpn=2Enet= /c/openvpn/+/1571/comment/29f53a5d_6b9aef7e?usp=3Demail : PS20, Line 135: = return hash_func((const uint8_t *)str, len, *(int32_t *)(hash_key)); Sho= uld be `uint32_t*` -- To view, visit http://gerrit=2Eopenvpn=2Enet/c/op= envpn/+/1571?usp=3Demail To unsubscribe, or for help writing mail filters, = visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-MessageTyp= e: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: = If47c7d920b2fa4047b7db03fcde821899839324d Gerrit-Change-Number: 1571 Gerrit= -PatchSet: 20 Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-R= eviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <o= penvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attention: plaisthos <arne-o= penvpn@rfc2549=2Eorg> Gerrit-Comment-Date: Thu, 30 Jul 2026 10:21:08 +0000 = Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --NrmgbwavIVE= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 20:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #ffd4d4;">Code-Review -1</span></p><p>The change is no longer sub= mittable: Code-Review is unsatisfied now=2E</p><p><a href=3D"http://gerrit= =2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail">View Change</a></p><p>2 comm= ents:</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0= ; padding: 0;"><p>File src/openvpn/mroute=2Ec:</p><ul style=3D"list-style: = none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style= =3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn= /+/1571/comment/400191c1_fbfefae1?usp=3Demail">Patch Set #20, Line 361:</a>= <code style=3D"font-family:monospace,monospace"> mrout= e_addr_hash_len((const struct mroute_addr *)key), *(int32_t *)hash_key);</c= ode></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: brea= k-word;">Should be `uint32_t*`</p></li></ul></li><li style=3D"margin: 0; pa= dding: 0;"><p>File tests/unit_tests/openvpn/test_misc=2Ec:</p><ul style=3D"= list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;= "><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet= /c/openvpn/+/1571/comment/29f53a5d_6b9aef7e?usp=3Demail">Patch Set #20, Lin= e 135:</a> <code style=3D"font-family:monospace,monospace"> return hash_= func((const uint8_t *)str, len, *(int32_t *)(hash_key));</code></p><p class= =3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">Should = be `uint32_t*`</p></li></ul></li></ul><p>To view, visit <a href=3D"http://g= errit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail">change 1571</a>=2E To u= nsubscribe, or for help writing mail filters, visit <a href=3D"http://gerri= t=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><div itemscope i= temtype=3D"http://schema=2Eorg/EmailMessage"><div itemscope itemprop=3D"act= ion" itemtype=3D"http://schema=2Eorg/ViewAction"><link itemprop=3D"url" hre= f=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail"/><meta ite= mprop=3D"name" content=3D"View Change"/></div></div> <div style=3D"display= :none"> Gerrit-MessageType: comment </div> <div style=3D"display:none"> Ger= rit-Project: openvpn </div> <div style=3D"display:none"> Gerrit-Branch: mas= ter </div> <div style=3D"display:none"> Gerrit-Change-Id: If47c7d920b2fa404= 7b7db03fcde821899839324d </div> <div style=3D"display:none"> Gerrit-Change-= Number: 1571 </div> <div style=3D"display:none"> Gerrit-PatchSet: 20 </div>= <div style=3D"display:none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2= 549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Reviewer: flichten= held <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none"> Ge= rrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> </di= v> <div style=3D"display:none"> Gerrit-Attention: plaisthos <arne-openvp= n@rfc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Comment-Date= : Thu, 30 Jul 2026 10:21:08 +0000 </div> <div style=3D"display:none"> Gerri= t-HasComments: Yes </div> <div style=3D"display:none"> Gerrit-Has-Labels: Y= es </div> </body></html> --NrmgbwavIVE=-- --===============7265226882522976115== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7265226882522976115== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============7265226882522976115==--