[Openvpn-devel] [M] Change in openvpn[master]: Replace SHA256 with SIPHASH24 in hamc cookie approach
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 10:35:18 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <b16eacb3971c7804c85ba37ac5ce78d322a66422-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============8894535985310260364== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fiGkTREc8EY="; charset=UTF-8 --fiGkTREc8EY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1827?usp=3Demail ) Change subject: Replace SHA256 with SIPHASH24= in hamc cookie approach =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 1: Code-Review-1 (3 comments) Commit Message: h= ttp://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/90b2076c_3146e3f2?usp= =3Demail : PS1, Line 7: Replace SHA256 with SIPHASH24 in hamc cookie approa= ch "hmac" File src/openvpn/ssl_pkt=2Ec: http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1827/comment/fe92a7a8_f46cb7fb?usp=3Demail : PS1, Line 458: /= * ensure out input is large enough */ "our" http://gerrit=2Eopenvpn=2Enet= /c/openvpn/+/1827/comment/60749da3_4d0ef657?usp=3Demail : PS1, Line 481: = /* add session id of client */ obsolete comment? or missing code? -- = To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827?usp=3Demail T= o unsubscribe, or for help writing mail filters, visit http://gerrit=2Eopen= vpn=2Enet/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project:= openvpn Gerrit-Branch: master Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23ea= bf04fe8e06d6fc3 Gerrit-Change-Number: 1827 Gerrit-PatchSet: 1 Gerrit-Owner:= plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichtenheld <fran= k@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esource= forge=2Enet> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerri= t-Comment-Date: Thu, 30 Jul 2026 10:35:18 +0000 Gerrit-HasComments: Yes Ger= rit-Has-Labels: Yes --fiGkTREc8EY= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 1:<span style=3D"borde= r-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgroun= d-color: #ffd4d4;">Code-Review -1</span></p><p><a href=3D"http://gerrit=2Eo= penvpn=2Enet/c/openvpn/+/1827?usp=3Demail">View Change</a></p><p>3 comments= :</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pa= dding: 0;"><p>Commit Message:</p><ul style=3D"list-style: none; padding: 0;= "><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: = 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/90b= 2076c_3146e3f2?usp=3Demail">Patch Set #1, Line 7:</a> <code style=3D"font-f= amily:monospace,monospace">Replace SHA256 with SIPHASH24 in hamc cookie app= roach</code></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wr= ap: break-word;">"hmac"</p></li></ul></li><li style=3D"margin: 0;= padding: 0;"><p>File src/openvpn/ssl_pkt=2Ec:</p><ul style=3D"list-style: = none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style= =3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn= /+/1827/comment/fe92a7a8_f46cb7fb?usp=3Demail">Patch Set #1, Line 458:</a> = <code style=3D"font-family:monospace,monospace"> /* ensure out input is = large enough */</code></p><p class=3D"blocks" style=3D"white-space: pre-wra= p; word-wrap: break-word;">"our"</p></li><li style=3D"margin: 0; = padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://ge= rrit=2Eopenvpn=2Enet/c/openvpn/+/1827/comment/60749da3_4d0ef657?usp=3Demail= ">Patch Set #1, Line 481:</a> <code style=3D"font-family:monospace,monospac= e"> /* add session id of client */</code></p><p class=3D"blocks" style= =3D"white-space: pre-wrap; word-wrap: break-word;">obsolete comment? or mis= sing code?</p></li></ul></li></ul><p>To view, visit <a href=3D"http://gerri= t=2Eopenvpn=2Enet/c/openvpn/+/1827?usp=3Demail">change 1827</a>=2E To unsub= scribe, or for help writing mail filters, visit <a href=3D"http://gerrit=2E= openvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><div itemscope itemt= ype=3D"http://schema=2Eorg/EmailMessage"><div itemscope itemprop=3D"action"= itemtype=3D"http://schema=2Eorg/ViewAction"><link itemprop=3D"url" href=3D= "http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1827?usp=3Demail"/><meta itempro= p=3D"name" content=3D"View Change"/></div></div> <div style=3D"display:non= e"> Gerrit-MessageType: comment </div> <div style=3D"display:none"> Gerrit-= Project: openvpn </div> <div style=3D"display:none"> Gerrit-Branch: master = </div> <div style=3D"display:none"> Gerrit-Change-Id: I3b6bb178ffb2bb49981b= c23eabf04fe8e06d6fc3 </div> <div style=3D"display:none"> Gerrit-Change-Numb= er: 1827 </div> <div style=3D"display:none"> Gerrit-PatchSet: 1 </div> <div= style=3D"display:none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2549= =2Eorg> </div> <div style=3D"display:none"> Gerrit-Reviewer: flichtenhel= d <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none"> Gerri= t-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> </div> = <div style=3D"display:none"> Gerrit-Attention: plaisthos <arne-openvpn@r= fc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Comment-Date: T= hu, 30 Jul 2026 10:35:18 +0000 </div> <div style=3D"display:none"> Gerrit-H= asComments: Yes </div> <div style=3D"display:none"> Gerrit-Has-Labels: Yes = </div> </body></html> --fiGkTREc8EY=-- --===============8894535985310260364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============8894535985310260364== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============8894535985310260364==--