[Openvpn-devel] [S] Change in openvpn[master]: Add aws-lc siphash implementation
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 11:39:14 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <5f21d441013ff5df75ff49b149662d3bb90424b0-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============1943219345383298973== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="RMEMc8Vtnlc="; charset=UTF-8 --RMEMc8Vtnlc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld=2E plaisthos has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1572?usp=3Demail ) Change subject: Add aws-lc siphash implementa= tion =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 21: (2 comments) File src/openvpn/siphash=2Eh: http://gerrit=2Eopenv= pn=2Enet/c/openvpn/+/1572/comment/269bfc1b_1414f2fd?usp=3Demail : PS21, Lin= e 43: * @param in: pointer to input data (read-only) > I don't think the= ":" makes sense in doxygen Acknowledged http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1572/comment/fc523b81_b0ba030d?usp=3Demail : PS21, Line 57: r= eturn 0; > Can we please have a documentation for the return value=2E Also = above in siphash_reference=2E I removed the return type as we no longer use= OpenSSL and the other two implementation cannot fail and need no return ty= pe=2E -- To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572?= usp=3Demail To unsubscribe, or for help writing mail filters, visit http://= gerrit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-MessageType: comment Ge= rrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I05e20f8c8249= 4e4abf96fe1e3a73e1c7b9101af6 Gerrit-Change-Number: 1572 Gerrit-PatchSet: 21= Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flic= htenheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@= lists=2Esourceforge=2Enet> Gerrit-Attention: flichtenheld <frank@lichtenhel= d=2Ecom> Gerrit-Comment-Date: Thu, 30 Jul 2026 11:39:14 +0000 Gerrit-HasCom= ments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <frank@l= ichtenheld=2Ecom> --RMEMc8Vtnlc= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: flichtenheld=2E </p> <p><a href=3D"http://gerrit=2Eop= envpn=2Enet/c/openvpn/+/1572?usp=3Demail">View Change</a></p><p>2 comments:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>File src/openvpn/siphash=2Eh:</p><ul style=3D"list-style: none= ; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"ma= rgin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/157= 2/comment/269bfc1b_1414f2fd?usp=3Demail">Patch Set #21, Line 43:</a> <code = style=3D"font-family:monospace,monospace"> * @param in: pointer to input = data (read-only)</code></p><p><blockquote style=3D"border-left: 1px solid #= aaa; margin: 10px 0; padding: 0 10px;">I don't think the ":" = makes sense in doxygen</blockquote></p><p class=3D"blocks" style=3D"white-s= pace: pre-wrap; word-wrap: break-word;">Acknowledged</p></li><li style=3D"m= argin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D= "http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572/comment/fc523b81_b0ba030d?u= sp=3Demail">Patch Set #21, Line 57:</a> <code style=3D"font-family:monospac= e,monospace"> return 0;</code></p><p><blockquote style=3D"border-left: 1= px solid #aaa; margin: 10px 0; padding: 0 10px;">Can we please have a docum= entation for the return value=2E Also above in siphash_reference=2E</blockq= uote></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: bre= ak-word;">I removed the return type as we no longer use OpenSSL and the oth= er two implementation cannot fail and need no return type=2E</p></li></ul><= /li></ul><p>To view, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openv= pn/+/1572?usp=3Demail">change 1572</a>=2E To unsubscribe, or for help writi= ng mail filters, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/settings?us= p=3Demail">settings</a>=2E</p><div itemscope itemtype=3D"http://schema=2Eor= g/EmailMessage"><div itemscope itemprop=3D"action" itemtype=3D"http://schem= a=2Eorg/ViewAction"><link itemprop=3D"url" href=3D"http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/1572?usp=3Demail"/><meta itemprop=3D"name" content=3D"Vi= ew Change"/></div></div> <div style=3D"display:none"> Gerrit-MessageType: = comment </div> <div style=3D"display:none"> Gerrit-Project: openvpn </div> = <div style=3D"display:none"> Gerrit-Branch: master </div> <div style=3D"dis= play:none"> Gerrit-Change-Id: I05e20f8c82494e4abf96fe1e3a73e1c7b9101af6 </d= iv> <div style=3D"display:none"> Gerrit-Change-Number: 1572 </div> <div sty= le=3D"display:none"> Gerrit-PatchSet: 21 </div> <div style=3D"display:none"= > Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> <div st= yle=3D"display:none"> Gerrit-Reviewer: flichtenheld <frank@lichtenheld= =2Ecom> </div> <div style=3D"display:none"> Gerrit-CC: openvpn-devel <= ;openvpn-devel@lists=2Esourceforge=2Enet> </div> <div style=3D"display:n= one"> Gerrit-Attention: flichtenheld <frank@lichtenheld=2Ecom> </div>= <div style=3D"display:none"> Gerrit-Comment-Date: Thu, 30 Jul 2026 11:39:1= 4 +0000 </div> <div style=3D"display:none"> Gerrit-HasComments: Yes </div> = <div style=3D"display:none"> Gerrit-Has-Labels: No </div> <div style=3D"dis= play:none"> Comment-In-Reply-To: flichtenheld <frank@lichtenheld=2Ecom&g= t; </div> </body></html> --RMEMc8Vtnlc=-- --===============1943219345383298973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1943219345383298973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============1943219345383298973==--