[Openvpn-devel] [M] Change in openvpn[master]: Change hash iv to a be a fixed sized array
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 16:01:00 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <fe0a49367c15718c6edf2b4c49fc4243f21c5afa-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============6547362402584586119==
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="+CVwSRqHk6I="; charset=UTF-8
--+CVwSRqHk6I=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld=2E
plaisthos has posted=
comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/=
openvpn/+/1571?usp=3Demail )
Change subject: Change hash iv to a be a fixe=
d sized array
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
Patch Set 20:
(4 comments)
File src/openvpn/list=2Ec:
http://gerrit=
=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/df7e5f88_b8113cd6?usp=3Demail :
P=
S19, Line 425: hash_func_new_ctx(void)
> forgot to remove?
yes=2E Removed
=
File src/openvpn/mroute=2Ec:
http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/15=
71/comment/c129ac68_53fe4557?usp=3Demail :
PS20, Line 361: =
mroute_addr_hash_len((const struct mroute_addr *)key), *(int32_t *)has=
h_key);
> Should be `uint32_t*`
Done
File src/openvpn/multi=2Ec:
http://=
gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/f195ffaa_13f23ddc?usp=3Dema=
il :
PS19, Line 313: * value and function for the context parameters=
=2E
> comment is obsolete
Done
File tests/unit_tests/openvpn/test_misc=2E=
c:
http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/37bb3b03_050c364=
d?usp=3Demail :
PS20, Line 135: return hash_func((const uint8_t *)str, =
len, *(int32_t *)(hash_key));
> Should be `uint32_t*`
Done
--
To view, =
visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail
To unsubsc=
ribe, or for help writing mail filters, visit http://gerrit=2Eopenvpn=2Enet=
/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
=
Gerrit-Branch: master
Gerrit-Change-Id: If47c7d920b2fa4047b7db03fcde8218998=
39324d
Gerrit-Change-Number: 1571
Gerrit-PatchSet: 20
Gerrit-Owner: plaisth=
os <arne-openvpn@rfc2549=2Eorg>
Gerrit-Reviewer: flichtenheld <frank@lichte=
nheld=2Ecom>
Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2E=
net>
Gerrit-Attention: flichtenheld <frank@lichtenheld=2Ecom>
Gerrit-Commen=
t-Date: Thu, 30 Jul 2026 16:01:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-=
Labels: No
Comment-In-Reply-To: flichtenheld <frank@lichtenheld=2Ecom>
--+CVwSRqHk6I=
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur=
rently required from: flichtenheld=2E </p>
<p><a href=3D"http://gerrit=2Eop=
envpn=2Enet/c/openvpn/+/1571?usp=3Demail">View Change</a></p><p>4 comments:=
</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad=
ding: 0;"><p>File src/openvpn/list=2Ec:</p><ul style=3D"list-style: none; p=
adding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margi=
n-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/c=
omment/df7e5f88_b8113cd6?usp=3Demail">Patch Set #19, Line 425:</a> <code st=
yle=3D"font-family:monospace,monospace">hash_func_new_ctx(void)</code></p><=
p><blockquote style=3D"border-left: 1px solid #aaa; margin: 10px 0; padding=
: 0 10px;">forgot to remove?</blockquote></p><p class=3D"blocks" style=3D"w=
hite-space: pre-wrap; word-wrap: break-word;">yes=2E Removed</p></li></ul><=
/li><li style=3D"margin: 0; padding: 0;"><p>File src/openvpn/mroute=2Ec:</p=
><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; paddin=
g: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=
=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/c129ac68_53fe4557?usp=3Demail">Pa=
tch Set #20, Line 361:</a> <code style=3D"font-family:monospace,monospace">=
mroute_addr_hash_len((const struct mroute_addr *)key),=
*(int32_t *)hash_key);</code></p><p><blockquote style=3D"border-left: 1px =
solid #aaa; margin: 10px 0; padding: 0 10px;">Should be `uint32_t*`</blockq=
uote></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: bre=
ak-word;">Done</p></li></ul></li><li style=3D"margin: 0; padding: 0;"><p>Fi=
le src/openvpn/multi=2Ec:</p><ul style=3D"list-style: none; padding: 0;"><l=
i style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;=
"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/f195ffa=
a_13f23ddc?usp=3Demail">Patch Set #19, Line 313:</a> <code style=3D"font-fa=
mily:monospace,monospace"> * value and function for the context paramet=
ers=2E</code></p><p><blockquote style=3D"border-left: 1px solid #aaa; margi=
n: 10px 0; padding: 0 10px;">comment is obsolete</blockquote></p><p class=
=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">Done</p=
></li></ul></li><li style=3D"margin: 0; padding: 0;"><p>File tests/unit_tes=
ts/openvpn/test_misc=2Ec:</p><ul style=3D"list-style: none; padding: 0;"><l=
i style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4px;=
"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571/comment/37bb3b0=
3_050c364d?usp=3Demail">Patch Set #20, Line 135:</a> <code style=3D"font-fa=
mily:monospace,monospace"> return hash_func((const uint8_t *)str, len, *=
(int32_t *)(hash_key));</code></p><p><blockquote style=3D"border-left: 1px =
solid #aaa; margin: 10px 0; padding: 0 10px;">Should be `uint32_t*`</blockq=
uote></p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: bre=
ak-word;">Done</p></li></ul></li></ul><p>To view, visit <a href=3D"http://g=
errit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail">change 1571</a>=2E To u=
nsubscribe, or for help writing mail filters, visit <a href=3D"http://gerri=
t=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><div itemscope i=
temtype=3D"http://schema=2Eorg/EmailMessage"><div itemscope itemprop=3D"act=
ion" itemtype=3D"http://schema=2Eorg/ViewAction"><link itemprop=3D"url" hre=
f=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1571?usp=3Demail"/><meta ite=
mprop=3D"name" content=3D"View Change"/></div></div>
<div style=3D"display=
:none"> Gerrit-MessageType: comment </div>
<div style=3D"display:none"> Ger=
rit-Project: openvpn </div>
<div style=3D"display:none"> Gerrit-Branch: mas=
ter </div>
<div style=3D"display:none"> Gerrit-Change-Id: If47c7d920b2fa404=
7b7db03fcde821899839324d </div>
<div style=3D"display:none"> Gerrit-Change-=
Number: 1571 </div>
<div style=3D"display:none"> Gerrit-PatchSet: 20 </div>=
<div style=3D"display:none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2=
549=2Eorg> </div>
<div style=3D"display:none"> Gerrit-Reviewer: flichten=
held <frank@lichtenheld=2Ecom> </div>
<div style=3D"display:none"> Ge=
rrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> </di=
v>
<div style=3D"display:none"> Gerrit-Attention: flichtenheld <frank@li=
chtenheld=2Ecom> </div>
<div style=3D"display:none"> Gerrit-Comment-Date=
: Thu, 30 Jul 2026 16:01:00 +0000 </div>
<div style=3D"display:none"> Gerri=
t-HasComments: Yes </div>
<div style=3D"display:none"> Gerrit-Has-Labels: N=
o </div>
<div style=3D"display:none"> Comment-In-Reply-To: flichtenheld <=
;frank@lichtenheld=2Ecom> </div>
</body></html>
--+CVwSRqHk6I=--
--===============6547362402584586119==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--===============6547362402584586119==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
--===============6547362402584586119==--