[Openvpn-devel] [M] Change in openvpn[master]: dco: do not exit the process when installing a DCO key fails

Attention is currently required from: plaisthos, ralf_lici.

ordex has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email )

Change subject: dco: do not exit the process when installing a DCO key fails
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS1: 
> The change looks good to me overall, but I wonder whether we could avoid adding the persistent bool  […]
I took inspiration from your suggestion, but I did not go the full way as you described because that flow had other drawbacks.
Still, patchset2 should be a good compromise :-) I hope you like it



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I564edc6e0cc179c2b8b5ddef5e80838949fe9fcd
Gerrit-Change-Number: 1835
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ralf_lici <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 11:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ralf_lici <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel