[Openvpn-devel] [S] Change in openvpn[master]: Make required action returned from pre_decrypt_verdict more explicit

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email )

Change subject: Make required action returned from pre_decrypt_verdict more explicit
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Patchset:

PS4: 
Needs more explanation, best added as in-code documentation.


File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1826/comment/2bb3363f_a8fbd3eb?usp=email :
PS4, Line 83: /* Returns true if this packet should create a new session */
Obsolete comment. Please add some explanation here about the different states.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iccdd4cfad090c565aac27e16cdaa9871106c2f89
Gerrit-Change-Number: 1826
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 14:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel