[Openvpn-devel] [M] Change in openvpn[master]: dco: do not exit the process when installing a DCO key fails

Attention is currently required from: ordex, ralf_lici.

plaisthos has posted comments on this change by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email )

Change subject: dco: do not exit the process when installing a DCO key fails
......................................................................


Patch Set 2:

(2 comments)

File src/openvpn/ssl.h:

http://gerrit.openvpn.net/c/openvpn/+/1835/comment/72747949_f0138f5d?usp=email :
PS2, Line 235: #define TLSMP_RESTART   4
Since you explicitly link that to DCO restart in forward.c maybe just give also a name like TLSMP_DCO_RESTART?


File src/openvpn/ssl_common.h:

http://gerrit.openvpn.net/c/openvpn/+/1835/comment/9ee4af76_5e7ca6cf?usp=email :
PS2, Line 202: };
Since that is only returned by the static method init_key_contexts inside ssl.c would it make sense to put this just above that method?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1835?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I564edc6e0cc179c2b8b5ddef5e80838949fe9fcd
Gerrit-Change-Number: 1835
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ralf_lici <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 14:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel