[Openvpn-devel] [M] Change in openvpn[master]: options: Change all users of positive_atoll to uint64_t
"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <614b6842bb15f9fc863b26beede4318715dfd6bc-EmailReviewComments-HTML@gerrit.openvpn.net> |
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1526?usp=email ) Change subject: options: Change all users of positive_atoll to uint64_t ...................................................................... Patch Set 9: (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1526/comment/f34cf083_c78178c3?usp=email : PS9, Line 869: o->renegotiate_seconds_min = 0; Setting this to 0 is now a noop as it is already set to 0 through the CLEAR(*o). Since a lot of other options rely on being implicitly set to 0 I would remove the assignments here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1526?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I701452496bb47c58b9728b08104dd5cb7823a94f Gerrit-Change-Number: 1526 Gerrit-PatchSet: 9 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sat, 08 Aug 2026 13:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel