[Openvpn-devel] [PATCH applied] Re: Hide various functions when unused

Gert Doering <[email protected]>
Newsgroups net.sourceforge.lists.openvpn-devel
Message-ID <[email protected]>
I'm not a big fan of adding #ifdef, but I understand the underlying goal
"make sure cppcheck results are meaningful, and not 100s of lines of
we-know-about-this".

Of course I'd much prefer to get rid of conditionals like PORT_SHARE but
I'm afraid this is tied to operating system capabilities...

I have not tested this beyond a basic FreeBSD compile test (plus a bit
of stare-at-code) - and since most of this would bomb at compile time,
having BB all green is a good indicator :-)

Your patch has been applied to the master branch.

commit 6575d4521a02e8a48a280f7246af6714504a2a86
Author: Frank Lichtenheld
Date:   Sat Aug 8 15:31:58 2026 +0200

     Hide various functions when unused

     Signed-off-by: Frank Lichtenheld <[email protected]>
     Acked-by: Arne Schwabe <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1611
     Message-Id: <[email protected]>
     URL: https://www.mail-archive.com/[email protected]/msg38233.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.