[Openvpn-devel] [M] Change in openvpn[master]: Remove various useless assignments

Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1617?usp=email )

Change subject: Remove various useless assignments
......................................................................


Patch Set 11:

(1 comment)

File src/openvpn/console_builtin.c:

http://gerrit.openvpn.net/c/openvpn/+/1617/comment/ed7d4c69_3b98ea0a?usp=email :
PS11, Line 203:     msg(M_FATAL, "Sorry, but I can't get console input on this OS (%s)", prompt);
this loses return. M_FATAL means exit, but won't we get a compiler warning on the platforms which are not WIN32 and don't have termios? The fix would be moving "return red" in the end of function above #endif.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1617?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id0caa497c4ff1ad8743cb23f332f003b2d3393ed
Gerrit-Change-Number: 1617
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: stipa <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 12:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel