[Openvpn-devel] [M] Change in openvpn[master]: Support p2p NCP negotiation in p2mp mode

Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1719?usp=email )

Change subject: Support p2p NCP negotiation in p2mp mode
......................................................................


Patch Set 5:

(1 comment)

File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1719/comment/a7bac6e4_6df00243?usp=email :
PS5, Line 1896:     if (session->opt->mode != MODE_SERVER || multi->use_asymmetric_peer_id
Is this new condition needed?

If opt->mode == MODE_SERVER, this requires --tls_server, and THE new condition will always be false -> contributes nothing.

If opt->server is false - we cannot be in the server mode, so first condition is true -> again, new condition contributes nothing.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1719?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8f3545f703126dbe96f809e69ad351749b14b1e1
Gerrit-Change-Number: 1719
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: stipa <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 10:58:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel