[Openvpn-devel] [M] Change in openvpn[master]: packet_id: Avoid conversion warnings

Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email )

Change subject: packet_id: Avoid conversion warnings
......................................................................


Patch Set 8:

(2 comments)

File src/openvpn/packet_id.c:

http://gerrit.openvpn.net/c/openvpn/+/1407/comment/d746266a_5080ebe3?usp=email :
PS7, Line 255:             if (diff >= (packet_id_type)CIRC_LIST_SIZE(p->seq_list))
> Technically since CIRC_LIST_SIZE is no longer restricted to (int), this now opens up a theoretical p […]
Again you're confusing x_size and x_sizeof


http://gerrit.openvpn.net/c/openvpn/+/1407/comment/6fab0707_3187f2c9?usp=email :
PS7, Line 261:             {
> These brackets are confusing. […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1407?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib0584e8728701cca10ac5675c9cb0e6f5eb901ac
Gerrit-Change-Number: 1407
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 11:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel