[Openvpn-devel] [L] Change in openvpn[master]: options: Factor out options_string code from options.c

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email )

Change subject: options: Factor out options_string code from options.c
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2: 
There seems to be an include guard copy-paste issue here.


File src/openvpn/options_string.h:

http://gerrit.openvpn.net/c/openvpn/+/1773/comment/0dbef915_b41ba38a?usp=email :
PS2, Line 24: #define OPTIONS_SHOW_H
This looks wrong. A previous patch in this series already uses this include guard name in the options_show.h header, which now makes including both headers in the same compilation unit problematic.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6824058fc9c4efd48ceeb32d4164f97b2a243d85
Gerrit-Change-Number: 1773
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Sun, 16 Aug 2026 12:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel