[Openvpn-devel] [M] Change in openvpn[master]: Make required action returned from pre_decrypt_verdict more explicit

Attention is currently required from: flichtenheld, razvanc, stipa.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email )

Change subject: Make required action returned from pre_decrypt_verdict more explicit
......................................................................


Patch Set 8:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1826/comment/e3697b68_91d649b0?usp=email :
PS8, Line 10: is defined to decided if session_skip_to_pre_start should be used.
> Typo: "to decide".
Done


File src/openvpn/mudp.c:

http://gerrit.openvpn.net/c/openvpn/+/1826/comment/b376acc1_2bdb8e9f?usp=email :
PS8, Line 282:                  * state is using the same */
> This comment now appears to be stale.
Done


http://gerrit.openvpn.net/c/openvpn/+/1826/comment/0a45728d_36e85f12?usp=email :
PS8, Line 283:                 if (session_id_defined((&state.peer_session_id)))
> Is it possible for this check to be false here? […]
yepp, good idea



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1826?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iccdd4cfad090c565aac27e16cdaa9871106c2f89
Gerrit-Change-Number: 1826
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: stipa <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 11:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel