[Openvpn-devel] [S] Change in openvpn[master]: oob: advertise a connect_lifetime in the probe reply

Attention is currently required from: plaisthos.

stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1768?usp=email )

Change subject: oob: advertise a connect_lifetime in the probe reply
......................................................................


Patch Set 11:

(2 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1768/comment/8ac540fc_47e3261a?usp=email :
PS8, Line 11: handshake shortcut, letting a probing client reuse it as the server's
> the seconds the reply?
I will rephrase it - A server answering an out-of-band SERVER_PROBE now also advertises a connect_lifetime in the PROBE_REPLY: how long, in seconds, a probing client may reuse the reply as the server's HARD_RESET and start the three-way handshake at the third packet.


File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1768/comment/ddb4cfdd_7887bfe7?usp=email :
PS8, Line 258: }
> This scream that it needs to be refactored. […]
Agreed. Reply is now in/out - the function is now only sets the peer's session id, so parameters list goes from 10 to 5. As a side effect, commits adding --server-probe-reply and connect_lifetime no longer touch oob.h/oob.c



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1768?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib2b6c2246f9d9c0a505292ee8d879f714901ffae
Gerrit-Change-Number: 1768
Gerrit-PatchSet: 11
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 11:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel