[Openvpn-devel] [XL] Change in openvpn[master]: options: Factor out options display code from options.c

Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email )

Change subject: options: Factor out options display code from options.c
......................................................................


Patch Set 3:

(3 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1772/comment/8ef3198d_1b6bc81a?usp=email :
PS2, Line 931: static void
> This function is now preceeded by 2 blank lines.
Done


File src/openvpn/options_show.h:

http://gerrit.openvpn.net/c/openvpn/+/1772/comment/5e592a64_359f6cdc?usp=email :
PS2, Line 42: #endif
> Nit: missing `/* OPTIONS_SHOW_H */`
Done


File src/openvpn/options_show.c:

http://gerrit.openvpn.net/c/openvpn/+/1772/comment/4c10fd49_2a754157?usp=email :
PS2, Line 25: #endif
> Don't we want to #include "options_show.h" here, and include config. […]
Have added the #include there. But not sure whether I should include options_show.h here. We do not need anything from it?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I61762374c141662d596bbf88b64ca7f7472b5149
Gerrit-Change-Number: 1772
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 12:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel