[Openvpn-devel] [XL] Change in openvpn[master]: options: Factor out options display code from options.c

Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email )

Change subject: options: Factor out options display code from options.c
......................................................................


Patch Set 3:

(1 comment)

File src/openvpn/options_show.c:

http://gerrit.openvpn.net/c/openvpn/+/1772/comment/1076440b_9cbcbfa7?usp=email :
PS3, Line 29: #include "syshead.h"
> Looking at src/openvpn/lzo.c, it unconditionally includes this header. comp-lz4.c does too. […]
```
$ git grep --files-without-match syshead.h src/openvpn/*.c
src/openvpn/crypto_epoch.c
src/openvpn/options_parse.c
src/openvpn/push_util.c
src/openvpn/siphash_reference.c
```

The tradition is definitely to just include it. Only some very reason files dropped it when not necessary.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1772?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I61762374c141662d596bbf88b64ca7f7472b5149
Gerrit-Change-Number: 1772
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 12:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel