[Openvpn-devel] [L] Change in openvpn[master]: options: Factor out options_string code from options.c

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email )

Change subject: options: Factor out options_string code from options.c
......................................................................


Patch Set 4:

(2 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1773/comment/1e030744_23dbf499?usp=email :
PS4, Line 3739:  */
Should such Doxygen go to the header instead?


http://gerrit.openvpn.net/c/openvpn/+/1773/comment/e0501fb3_9668768f?usp=email :
PS4, Line 3932:  */
I _think_ the newline between this and the function below orphans the comment.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1773?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6824058fc9c4efd48ceeb32d4164f97b2a243d85
Gerrit-Change-Number: 1773
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 17 Aug 2026 18:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel