[Openvpn-devel] [M] Change in openvpn[master]: test_networking: Allow to test --netns

Attention is currently required from: flichtenheld, its_Giaan, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1586?usp=email )

Change subject: test_networking: Allow to test --netns
......................................................................


Patch Set 3:

(5 comments)

File tests/t_net.sh:

http://gerrit.openvpn.net/c/openvpn/+/1586/comment/96fc37e2_1e4267d8?usp=email :
PS3, Line 30:     $RUN_SUDO $IP_EXEC ip link set dev $IFACE state up
`$IP_EXEC` is already defined as calling `$RUN_SUDO`, so the `$RUN_SUDO` on these 3 line now appears to be superfluous.


http://gerrit.openvpn.net/c/openvpn/+/1586/comment/2c48207f_99e26859?usp=email :
PS3, Line 32:     if [ $? -ne 0 ]; then
Doesn't `set -e` exit before this can even be reached?


http://gerrit.openvpn.net/c/openvpn/+/1586/comment/072ad77b_f1c9c60c?usp=email :
PS3, Line 33:         echo "can't create interface $IFACE $IP_NETNS"
I can't find `IP_NETNS` as defined anywhere.


File tests/unit_tests/openvpn/test_networking.c:

http://gerrit.openvpn.net/c/openvpn/+/1586/comment/6a9933b2_a59067f2?usp=email :
PS3, Line 216:     printf("Usage: %s <0-8>\n", name);
Should `usage()` be changed as well now?


http://gerrit.openvpn.net/c/openvpn/+/1586/comment/d2ab3f93_912c2297?usp=email :
PS3, Line 246:         ctx->gc = gc_new();
Maybe acceptable because this is just a test, but we never check that `ctx` it not `NULL`.

There's also no corresponding `free()` for it.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1586?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf84cba0124320f7c49e28d1b3364dac9e8b6d9
Gerrit-Change-Number: 1586
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: its_Giaan <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 11:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel