[Openvpn-devel] [M] Change in openvpn[master]: Rename variables that shadow other variables or functions

Attention is currently required from: plaisthos, razvanc.

flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email )

Change subject: Rename variables that shadow other variables or functions
......................................................................


Patch Set 15:

(4 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/b0c7dc04_c3550c66?usp=email :
PS13, Line 3670:             struct dns_domain *new = *entry;
> Ouch! It might be a good idea to have an official guideline to not use C++ keywords as variable name […]
out of scope for this change, though


File src/openvpn/ps.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/2d807a05_85086416?usp=email :
PS13, Line 878:             msg(M_ERR, "PORT SHARE: unexpected init recv_control status=%d", status);
> But now we are probably printing the wrong `status` variable here. […]
Done


File tests/unit_tests/openvpn/test_dhcp.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/85abadc9_c9db387e?usp=email :
PS13, Line 58:     struct buffer clean_buf = alloc_buf_gc(512, &gc);
> I assume I wasn't that worried due to clear_buf() being a function.
not changing this


File tests/unit_tests/openvpn/test_push_update_msg.c:

http://gerrit.openvpn.net/c/openvpn/+/1618/comment/f2559df8_b9c3bf53?usp=email :
PS13, Line 347:     const char *cmsg1 = "PUSH_UPDATE, route 10.1.0.0 255.255.0.0, route 10.2.0.0 255.255.0.0, route 10.3.0.0 255.255.0.0,push-continuation 2";
> Maybe push_msg1 here (and the same strategy below)? Would it make it a bit clearer?
I did go for cont_msg since this is the continuation test



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1618?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I528f5fd200d877841e473e5e05b7ac7915fa2e33
Gerrit-Change-Number: 1618
Gerrit-PatchSet: 15
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Wed, 19 Aug 2026 15:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel