[Openvpn-devel] [S] Change in openvpn[master]: dev-tools/reformat-shell.sh: Make our shell code more consistent

cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1792?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by razvanc


Change subject: dev-tools/reformat-shell.sh: Make our shell code more consistent
......................................................................

dev-tools/reformat-shell.sh: Make our shell code more consistent

Our shell code is currently not very consistent about
formatting. So provide a tool to achieve that consistency.
Especially in our test code we have several important shell
scripts that we actively develop.

Change-Id: I80a94dde26631e5a665029f495b2104cfecb1915
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Razvan Cojocaru <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1792
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38546.html
Signed-off-by: Gert Doering <[email protected]>
---
A dev-tools/reformat-shell.sh
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/92/1792/5

diff --git a/dev-tools/reformat-shell.sh b/dev-tools/reformat-shell.sh
new file mode 100755
index 0000000..dbbdaa9
--- /dev/null
+++ b/dev-tools/reformat-shell.sh
@@ -0,0 +1,14 @@
+#!/bin/sh
+#
+# Apply consistent formatting to our shell code.
+# Uses shfmt: https://github.com/mvdan/sh
+
+set -u
+
+FORMAT_ARGS="--indent=4 --func-next-line --case-indent"
+FORMAT_CMD="shfmt --list --write"
+
+# hardcoded to --posix due to .in filename and invalid shebang
+$FORMAT_CMD --posix $FORMAT_ARGS ./tests/t_client.sh.in
+# handle *.sh files recursively
+$FORMAT_CMD $FORMAT_ARGS ./tests ./dev-tools

-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1792?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I80a94dde26631e5a665029f495b2104cfecb1915
Gerrit-Change-Number: 1792
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ralf_lici <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel