[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Work-around bug in mbedtls 4.1.0 and 4.2.0

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1849?usp=email )

Change subject: mbedtls: Work-around bug in mbedtls 4.1.0 and 4.2.0
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/mbedtls_compat.h:

http://gerrit.openvpn.net/c/openvpn/+/1849/comment/7bf7e771_e75277ab?usp=email :
PS1, Line 240:                                              (size_t *)&prv->MBEDTLS_PRIVATE(pub_raw_len))));
These two casts would build even if the types of the variables would change in the future.

Would it be good to cast the whole thing upfront, then no longer require the cast, e.g. `mbedtls_pk_context *mut_prv = (mbedtls_pk_context *)prv;` + use `mut_prv` (with no casts for individual data members)?



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1849?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I694410615958afbb422d9ead71f04c1a60edc640
Gerrit-Change-Number: 1849
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: MaxF <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 20 Aug 2026 10:28:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel