[Openvpn-devel] [M] Change in openvpn[master]: socket: Fix various conversion warnings

Attention is currently required from: flichtenheld, plaisthos.

razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1476?usp=email )

Change subject: socket: Fix various conversion warnings
......................................................................


Patch Set 9:

(2 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1476/comment/fcd0ba0e_871fb010?usp=email :
PS9, Line 6540:         if (strlen(p[1]) <= IFNAMSIZ)
This is an off-by-one issue.

Linux uses `IFNAMSIZ` as the total length for these buffers (e.g. `char ifr_name[IFNAMSIZ];  /* Interface name */`), which means that includes the `NUL` terminator.

I believe we want `<` here (instead of `<=`).


http://gerrit.openvpn.net/c/openvpn/+/1476/comment/0e07805a_1b855ae7?usp=email :
PS9, Line 6546:             msg(msglevel, "argument to --bind-dev is longer than allowed %u", IFNAMSIZ);
`IFNAMSIZ - 1`



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1476?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7be7427480d3540d43dd818eddb6eb5860956459
Gerrit-Change-Number: 1476
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 21 Aug 2026 08:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel