[Openvpn-devel] [S] Change in openvpn[master]: Make pull_permission_mask return uint64_t

"plaisthos \(Code Review\) via Openvpn-devel" <[email protected]>
Newsgroups net.sourceforge.lists.openvpn-devel
Message-ID <fb5099a5c0e8eba87d74479f5fc984dc91629568-EmailReviewComments-HTML@gerrit.openvpn.net>
Attention is currently required from: razvanc.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1851?usp=email )

Change subject: Make pull_permission_mask return uint64_t
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1851/comment/9a934e8b_b22ac1fb?usp=email :
PS1, Line 9: Commit 91fd9614 already change most of the instances for the
> Minor typo: "changed".
Done


File tests/unit_tests/openvpn/test_push_update_msg.c:

http://gerrit.openvpn.net/c/openvpn/+/1851/comment/c8eee815_61fc51be?usp=email :
PS1, Line 26:     unsigned int flags = OPT_P_UP | OPT_P_ROUTE_EXTRAS | OPT_P_SOCKBUF | OPT_P_SOCKFLAGS
> Should this stay `unsigned int`?
Done


http://gerrit.openvpn.net/c/openvpn/+/1851/comment/255bdbf8_750b98f9?usp=email :
PS1, Line 26:     unsigned int flags = OPT_P_UP | OPT_P_ROUTE_EXTRAS | OPT_P_SOCKBUF | OPT_P_SOCKFLAGS
> Should this stay `unsigned int`?
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1851?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icd53745b242e0ca2943863d5b274b2a13b4419bd
Gerrit-Change-Number: 1851
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Sun, 23 Aug 2026 13:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.