Re: [PATCH 5/5] Use __func__ instead of function name
Michael Ellerman <mpe-Gsx/[email protected]>
| Newsgroups | net.sourceforge.lists.tpmdd-devel,org.kernel.vger.linux-kernel,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
Michal Suchánek <[email protected]> writes: > On 2017-07-29 09:24, SZ Lin wrote: >> Fix following checkpatch.pl warning: >> WARNING: Prefer using '"%s...", __func__' to using >> the function's name, in a string >> >> Signed-off-by: SZ Lin <[email protected]> >> --- >> drivers/char/tpm/tpm_ibmvtpm.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c >> b/drivers/char/tpm/tpm_ibmvtpm.c >> index e75a674b44ac..2d33acc43e25 100644 >> --- a/drivers/char/tpm/tpm_ibmvtpm.c >> +++ b/drivers/char/tpm/tpm_ibmvtpm.c >> @@ -151,7 +151,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, >> u8 *buf, size_t count) >> rc = ibmvtpm_send_crq(ibmvtpm->vdev, be64_to_cpu(word[0]), >> be64_to_cpu(word[1])); >> if (rc != H_SUCCESS) { >> - dev_err(ibmvtpm->dev, "tpm_ibmvtpm_send failed rc=%d\n", rc); >> + dev_err(ibmvtpm->dev, "%s failed rc=%d\n", __func__, rc); > > Can function name contain a %? Let's hope not. $ git grep "%s.*__func__" | wc -l 16937 cheers ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel