Re: [PATCH v3 0/2] tpm_tis_spi: Use DMA-safe memory
<Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/[email protected]>
| Newsgroups | net.sourceforge.lists.tpmdd-devel |
|---|---|
| Message-ID | <[email protected]> |
> Hi Alexander, > > Obviously, we agree to cover validation with STM TPM to confirm your > update. > Following my availability, I cannot start it before mid of September. Is it inline > with your expectation ? As always, better than nothing, thanks :) > If it's the case, I will start : > - tpm_tis_spi on Raspberry PI 3 > Next > - tpm_tis on X86_64 Those patches only change tpm_tis_spi, so you can skip the tests with tpm_tis. > Could you send me patch file or link to get patch ? Unfortunately, Patchwork is not working anymore, so I'll send you the patches in a separate mail. > By taking Raspberry PI 3 example, How many Byte in SPI transfer size is > necessary to use DMA transfer ? The Raspberry Pi 3 uses drivers/spi/spi-bcm2835.c, which defines BCM2835_SPI_DMA_MIN_LENGTH = 96 bytes. The maximum frame size used by tpm_tis_spi is MAX_SPI_FRAMESIZE = 64 bytes, so the DMA code path is never taken. You could try to set BCM2835_SPI_DMA_MIN_LENGTH to a lower value, to force it to use DMA. > Best Regards, > > Benoit Alexander ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot