Re: [PATCH v3 01/10] fsdax: Factor helpers to simplify dax fault code
Ritesh Harjani <[email protected]>
| Newsgroups | org.01.lists.linux-nvdimm,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 3/19/21 7:22 AM, Shiyang Ruan wrote: > The dax page fault code is too long and a bit difficult to read. And it > is hard to understand when we trying to add new features. Some of the > PTE/PMD codes have similar logic. So, factor them as helper functions to > simplify the code. > > Signed-off-by: Shiyang Ruan <[email protected]> > Reviewed-by: Christoph Hellwig <[email protected]> > --- > fs/dax.c | 152 ++++++++++++++++++++++++++++++------------------------- > 1 file changed, 84 insertions(+), 68 deletions(-) > Refactoring & the changes looks good to me. Feel free to add. Reviewed-by: Ritesh Harjani <[email protected]> _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]