Re: [PATCH] powerpc/papr_scm: Mark nvdimm as unarmed if needed during probe

Vaibhav Jain <[email protected]> writes:

> In case an nvdimm is found to be unarmed during probe then set its
> NDD_UNARMED flag before nvdimm_create(). This would enforce a
> read-only access to the ndimm region. Presently even if an nvdimm is
> unarmed its not marked as read-only on ppc64 guests.
>
> The patch updates papr_scm_nvdimm_init() to force query of nvdimm
> health via __drc_pmem_query_health() and if nvdimm is found to be
> unarmed then set the nvdimm flag ND_UNARMED for nvdimm_create().
>

Reviewed-by: Aneesh Kumar K.V <[email protected]>

> Signed-off-by: Vaibhav Jain <[email protected]>
> ---
>  arch/powerpc/platforms/pseries/papr_scm.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index 835163f54244..7e8168e19427 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -914,6 +914,15 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p)
>  	dimm_flags = 0;
>  	set_bit(NDD_LABELING, &dimm_flags);
>  
> +	/*
> +	 * Check if the nvdimm is unarmed. No locking needed as we are still
> +	 * initializing. Ignore error encountered if any.
> +	 */
> +	__drc_pmem_query_health(p);
> +
> +	if (p->health_bitmap & PAPR_PMEM_UNARMED_MASK)
> +		set_bit(NDD_UNARMED, &dimm_flags);
> +
>  	p->nvdimm = nvdimm_create(p->bus, p, papr_nd_attr_groups,
>  				  dimm_flags, PAPR_SCM_DIMM_CMD_MASK, 0, NULL);
>  	if (!p->nvdimm) {
> -- 
> 2.30.2
> _______________________________________________
> Linux-nvdimm mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]