Re: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer
Andy Shevchenko <[email protected]> Fri, 16 Apr 2021 20:36:10 +0300
| Newsgroups | org.01.lists.linux-nvdimm,dev.linux.lists.nvdimm,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
| Message-ID | <[email protected]> |
On Thu, Apr 15, 2021 at 05:37:54PM +0300, Andy Shevchenko wrote: > Strictly speaking the comparison between guid_t and raw buffer > is not correct. Return to plain memcmp() since the data structures > haven't changed to use uuid_t / guid_t the current state of affairs > is inconsistent. Either it should be changed altogether or left > as is. Dan, please review this one as well. I think here you may agree with me. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]