Re: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer
Dan Williams <[email protected]> Fri, 16 Apr 2021 13:08:06 -0700
| Newsgroups | org.01.lists.linux-nvdimm,dev.linux.lists.nvdimm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAPcyv4iwiJwwgiisZTqk6F=A8hLJCGkK-4suqDMPYYiLzuLwFA@mail.gmail.com> |
[ add Erik ] On Fri, Apr 16, 2021 at 10:36 AM Andy Shevchenko <[email protected]> wrote: > > On Thu, Apr 15, 2021 at 05:37:54PM +0300, Andy Shevchenko wrote: > > Strictly speaking the comparison between guid_t and raw buffer > > is not correct. Return to plain memcmp() since the data structures > > haven't changed to use uuid_t / guid_t the current state of affairs > > is inconsistent. Either it should be changed altogether or left > > as is. > > Dan, please review this one as well. I think here you may agree with me. You know, this is all a problem because ACPICA is using a raw buffer. Erik, would it be possible to use the guid_t type in ACPICA? That would allow NFIT to drop some ugly casts. _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]