Re: [Virtio-fs] [PATCH v3 2/3] dax: Add a wakeup mode parameter to put_unlocked_entry()

Dan Williams <[email protected]> Mon, 17 May 2021 10:10:19 -0700
Newsgroups org.01.lists.linux-nvdimm,dev.linux.lists.virtio-fs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel
Message-ID <CAPcyv4jukTfMroXaw+zWELp4JM=kbBaitG1FGwFhxP7u1yQMBA@mail.gmail.com>
On Wed, Apr 21, 2021 at 11:25 PM Christoph Hellwig <[email protected]> wrote:
>
> On Wed, Apr 21, 2021 at 12:09:54PM -0700, Dan Williams wrote:
> > Can you get in the habit of not replying inline with new patches like
> > this? Collect the review feedback, take a pause, and resend the full
> > series so tooling like b4 and patchwork can track when a new posting
> > supersedes a previous one. As is, this inline style inflicts manual
> > effort on the maintainer.
>
> Honestly I don't mind it at all.  If you shiny new tooling can't handle
> it maybe you should fix your shiny new tooling instead of changing
> everyones workflow?

Fyi, shiny new tooling has been fixed:

http://lore.kernel.org/r/[email protected]

...it still requires properly formatted patches with commentary below
the "---" break line, but this should cut down on re-rolls.

Hat tip to Konstantin.
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]