Re: [PATCH 5/5] ASoC: amd: acp7x: add system and runtime PM ops
Mark Brown <[email protected]>
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Thu, May 07, 2026 at 02:33:47PM -0500, Mario Limonciello wrote:
> On 5/7/26 13:11, Vijendar Mukunda wrote:
> > +static int __maybe_unused snd_acp7x_resume(struct device *dev)
> > +{
> > + struct acp7x_dev_data *adata;
> > + int ret;
> > +
> > + adata = dev_get_drvdata(dev);
> > + ret = acp_hw_init(adata, dev);
> > + if (ret)
> > + dev_err(dev, "ACP init failed\n");
> > +
> > + return ret;
> > +}
> Both of snd_acp7x_runtime_resume and snd_acp7x_resume look identical. Will
> there be later code (when machine driver and IO enablement come) that makes
> them different?
> If not; then I think you can drop snd_acp7x_runtime_resume().
> If so; this makes sense to keep separately.
Not seeing any response to this question from Mario?
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmoO7bwACgkQJNaLcl1U h9BJFwf/TgWuvQ/NFuu19UEQCRcFImz0ttnm4CtFkgiEfYTwIuwp+BnZ/yPUW5Vk ZSOnwFeKQ6X8AITokenw8Au7xhfYuz+2tsK0RDEO8qOgqEeaSCuIBB2B9frAkU1c VLasKfi2O4/IGjCsXosWwaIhtLG4ciZNb5xYWn/6pxw5Bvz58AXKs+asR+yoNOdG +zO0BebJy+BwIbifbcSBPl0Uue52eq1/us328JjNxEdqctTw2hYz3XjnpH5GMnxX eeo7odR4KyEETTXfUB0Mvv3kQ/NjJI2h5lBmX50BTAEAzBKRKqFGJp/ZG8kc7K8S uCdfJebvBsPeyei/Uln49JKc6m3etg== =/UjV -----END PGP SIGNATURE-----