Re: [PATCH v4] ASoC: rt722-sdca: Add a control to support CAE firmware update
Mark Brown <[email protected]>
| Newsgroups | org.alsa-project.alsa-devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, May 20, 2026 at 01:32:43PM +0800, [email protected] wrote: > Realtek CAE requires specific tuning parameters based on > the system vendor and SKU. > This patch adds a kcontrol to trigger the firmware loading process. > + if (strcmp(tag, xu_tag) == 0) { > + dev_dbg(dev, "%s: This is a XU tag", __func__); > + memcpy(&addr, (fw_data + 4), 4); > + memcpy(&size, (fw_data + 8), 4); Sorry, should've thought of this before but the memcpy() will have endianness issues - these should get washed through appropriate conversion functions so the driver will work on non-x86 systems. I'll apply the patch since everything else looks good, but you might want to follow up fixing the endianness.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmoNnAcACgkQJNaLcl1U h9DA+Af/ZQtQ3U7PYDFcn54Wdzj/zLBdghP1mCkbZpHCrXp3Ud29fBdgVZPeGz2O wmXGKrkwKu/eow90etDdShqJ8xzsAtqx81lMp+2n/ELUHO6h4Rv4wQYxOuF6VKQ6 0U6+30Y6QbGg5R+4vHcgPcOEXBYmhIkcio4uztlHVDdjfaeXqPC3wVX8iR57PIrS aEg4zzolrcz5M+xP+JgPpweCcs8Lf89ELEE1+AAtJ4DJy/yKsS+m/NztvBO8fY0N Tq1Gr4Q8FmfOUuxO4o0KyAvYPL/KWPfBQ1OwKNdltlPX/q/A/hkS3PNKYzUC0Rh2 Zka28Jc/k9Na8i8argjLAqXcFaM49A== =qHwu -----END PGP SIGNATURE-----