Re: [PATCH] ASoC: amd: yc: Enable internal mic on MSI Bravo 17 C7VF

Geraldo Nascimento <[email protected]>
Newsgroups org.alsa-project.alsa-devel,org.kernel.vger.linux-sound
Message-ID <ahIU9X2DizdyQVR8@geday>
Hi João Miguel,

On Sat, May 23, 2026 at 05:36:52PM +0100, João Miguel wrote:
> From: João Miguel <[email protected]>
> 
> the board's internal DMIC is on the ACP6x and isn't detected without a DMI quirk entry; this adds it.
> ---
>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>

While the patch itself looks OK, you're missing the required
Signed-off-by tag, which should contain your legal name with surname
(I'm assuming Miguel is not your surname, correct me if I'm wrong).

Also, please wrap the commit message at 72 characters. The way it is
now makes a very long line hard to read in standard terminals.

Thank you,
Geraldo Nascimento

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 7a637d6b5..a93a7fd48 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -794,6 +794,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "M7601RM"),
>  		}
>  	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
> +			DMI_MATCH(DMI_BOARD_NAME, "MS-17LN"),
> +		}
> +	},
>  	{}
>  };
>  
> -- 
> 2.54.0
> 
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.