Re: [PATCH v3 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier
Mark Brown <[email protected]>
| Newsgroups | org.alsa-project.alsa-devel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Fri, May 29, 2026 at 04:49:11PM +0800, YLCHANG2 wrote: > On 5/27/26 21:43, Mark Brown wrote: > > On Tue, May 26, 2026 at 09:58:26AM +0800, Neo Chang wrote: > > https://sashiko.dev/#/patchset/20260526015826.440769-1-YLCHANG2%40nuvoton.com > Regarding the sashiko report, I have a few questions: > Are we required to address every issue caught by sashiko? We found that some > of them are actually false positives. > If we need to explain our code regarding sashiko's findings, who should we > send the reply to? Just address anything that looks legitimate and ignore the rest. Part of the reason I only linked to the review is that I didn't have time to verify what was accurate in there. > Additionally, is there a way to run the sashiko checks locally before > submitting our patches? You can install it locally, the code for the service itself is available, but these things being what they are you can't rely on the output being exactly the same.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmoZfyYACgkQJNaLcl1U h9Dw/wf/SkgXf8IGxg4KAoclYOkN8Wtjlo+8RpQ79pg0XPSoj92+E09CqQOaW28S 4JRXCkA7YKwsDEpldMqAiCajCafVnlprnH6FrRyhOBUGyeWEyVD5NdV166gl9rRp YSKXy1AxWE025Eib+QfR5CL1GXTlPLSl44mNok1lpaBW4VHPT2jDY9i1Md6tlKUC 6NPYtuYXeyBSgafHPtH1c1OJX09JyWsraRqMN6cFc2YQqpTAU9FR1SeBDmK/7CxC 4IO7WSR5B/10EkDAIBLSPFqDsnwO2EFu2jOGlletvES9QWgo+vyJcrkkI+9wYfut g/99OTYNG0sf0eLH9Lk5e8majrOoUA== =jpYX -----END PGP SIGNATURE-----