Re: [PATCH v3 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60

On 5/27/26 17:15, Krzysztof Kozlowski wrote:
> On Tue, May 26, 2026 at 09:58:25AM +0800, Neo Chang wrote:
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: mclk
>> +
>> +  nuvoton,dsp-bypass:
>> +    type: boolean
>> +    description:
>> +      Forcibly disable/bypass DSP path.
> Same questions as v1. Properties are not to control your probe() in the
> driver, but to describe the hardware.
>
> You have entire description or commit msg to convince that previously
> questioned property is still reasonable in terms of DT.
>
> OTOH, isn't lack of firmware binaries enough to deduce that DSP is not
> going to be used?
Got it. I will drop this property in v4. As you mentioned, the firmware 
presence is enough.
>
>> +
>> +  nuvoton,pbtl-enable:
>> +    type: boolean
>> +    description:
>> +      NAU83G60 supports PBTL mode for mono output.
>> +
>> +  nuvoton,dac-cur-enable:
>> +    type: boolean
>> +    description:
>> +      Adjust DAC output current to match speaker impedance and prevent
>> +      hardware damage. +3.2dB when present, 0dB by default.
>> +
>> +  firmware-name:
>> +    minItems: 2
>> +    maxItems: 2
>> +    description:
>> +      Assign firmware filenames for left and right DSP cores.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +allOf:
>> +  - $ref: dai-common.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        codec@1a {
>> +            #sound-dai-cells = <0>;
> Please follow DTS coding style.
Thanks for the suggestion. I will follow dts-coding-style.rst in v4.
>
> Best regards,
> Krzysztof
>